<html>
<head><meta charset="utf-8"><title>triage 2021 07 13 · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html">triage 2021 07 13</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="245833127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245833127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245833127">(Jul 13 2021 at 14:30)</a>:</h4>
<p>ok, going to start triage -- trying out the endpoint</p>



<a name="245835939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245835939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245835939">(Jul 13 2021 at 14:50)</a>:</h4>
<p>endpoint seems to have worked well</p>



<a name="245836011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245836011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245836011">(Jul 13 2021 at 14:50)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@rylev</span> did we end up with some docs on handling nag carry-over? It looks like there's several "untriaged" regressions - <a href="https://github.com/rust-lang/rust/issues?q=is%3Amerged+label%3Aperf-regression+-label%3Aperf-regression-triaged+">https://github.com/rust-lang/rust/issues?q=is%3Amerged+label%3Aperf-regression+-label%3Aperf-regression-triaged+</a></p>



<a name="245836286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245836286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245836286">(Jul 13 2021 at 14:52)</a>:</h4>
<p>No we did not. Some thoughts:</p>
<ul>
<li>Add untriaged perf issues to the triage report</li>
<li>Ping author/reviewer to address the issue</li>
</ul>



<a name="245836351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245836351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245836351">(Jul 13 2021 at 14:52)</a>:</h4>
<p>Question becomes if the regression is constantly unaddressed, what do we do</p>



<a name="245836414"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245836414" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245836414">(Jul 13 2021 at 14:53)</a>:</h4>
<p>(also, we can easily add the untriaged perf issues to the triage report automatically)</p>



<a name="245837820"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245837820" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245837820">(Jul 13 2021 at 15:01)</a>:</h4>
<p>I think adding them automatically makes sense</p>



<a name="245837856"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245837856" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245837856">(Jul 13 2021 at 15:01)</a>:</h4>
<p>I'll just include a listing manually for now</p>



<a name="245837962"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245837962" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245837962">(Jul 13 2021 at 15:01)</a>:</h4>
<p>I think we shouldn't ping just yet -- let's see if maybe we can get T-compiler or folks on prioritization etc to assign/handle that</p>



<a name="245838047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245838047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245838047">(Jul 13 2021 at 15:01)</a>:</h4>
<p>(it's possible investigation is best done by not the author in some cases)</p>



<a name="245838984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245838984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245838984">(Jul 13 2021 at 15:06)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-perf/pull/904">https://github.com/rust-lang/rustc-perf/pull/904</a></p>



<a name="245845174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245845174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245845174">(Jul 13 2021 at 15:49)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/triage.202021.2007.2013/near/245837962">said</a>:</p>
<blockquote>
<p>I think we shouldn't ping just yet -- let's see if maybe we can get T-compiler or folks on prioritization etc to assign/handle that</p>
</blockquote>
<p>How do you want to handle getting such a process set up? Would you like to propose this in the next compiler meeting? I think it's fine for T-compiler folks to be in charge as long as T-performance folks make sure it gets done eventually</p>



<a name="245846255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245846255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245846255">(Jul 13 2021 at 15:57)</a>:</h4>
<p>I think we can accumulate for now, it looks like at least some are getting labeled as triaged. We're not seeing too many so far. Maybe T-compiler can discuss in meeting or a planning meeting can be spun out of some brief discussion.</p>
<p>cc <span class="user-mention" data-user-id="116083">@pnkfelix</span></p>



<a name="245847629"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/triage%202021%2007%2013/near/245847629" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/triage.202021.2007.2013.html#245847629">(Jul 13 2021 at 16:06)</a>:</h4>
<p>I opened an issue for adding them automatically to the triage report <a href="https://github.com/rust-lang/rustc-perf/issues/905">https://github.com/rust-lang/rustc-perf/issues/905</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>